NXP backend: Test avg_pool2d with new Neutron flow.#19147
NXP backend: Test avg_pool2d with new Neutron flow.#19147MartinPavella wants to merge 4 commits intopytorch:mainfrom
Conversation
MartinPavella
added
the
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19147
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 16 New Failures, 1 Unrelated FailureAs of commit 0394b4d with merge base b4d4507 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
Based on another PR: #19112 |
This PR needs a
|
|
Note that neutron unit tests are failing. |
MartinPavella
force-pushed
the
nxg01483/EIEX-858-add-avg_pool2d-support-using-new-neutron-flow
branch
from
737f772 to
0394b4d
Compare
| from executorch.backends.nxp.tests.use_qat import * # noqa F403 | ||
| from executorch.exir.dialects._ops import ops as exir_ops | ||
|
|
||
| AvgPool2D = exir_ops.edge.aten.avg_pool2d.default |
There was a problem hiding this comment.
What about creating a file with aliases for all tests? This way we would need to define it everywhere.
|
|
||
| if any(s > 4096 for s in stride): | ||
| return False | ||
|
|
There was a problem hiding this comment.
I think we should also check the input types as they are specified in docs.
| # not create any NeutronGraph that can be called. This is done by the partitioner itself, and is not handled by | ||
| # the individual node converters. | ||
| allow_no_op_partitions: bool = False | ||
|
|
There was a problem hiding this comment.
Some comment would be good here.
| ) | ||
|
|
||
| lower_run_compare( | ||
| model, input_shape, graph_verifier, use_new_flow_neutron_c=True |
There was a problem hiding this comment.
Setting use_new_flow_neutron_c=True just here is not enough, it won't be passed to custom_delegation_options in partitioner.
There was a problem hiding this comment.
Exactly what I wanted to comment few hours ago but had to go... 😀
4 participants
Summary
Add tests verifying correct support for
avg_pool2dby the Neutron backend using the new Neutron MLIR flow.Test plan
Unit tests provided.
cc @robert-kalmar @JakeStevens @digantdesai